[ 
https://issues.apache.org/jira/browse/HIVE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136716#comment-13136716
 ] 

jirapos...@reviews.apache.org commented on HIVE-2247:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1105/
-----------------------------------------------------------

(Updated 2011-10-27 02:14:56.306830)


Review request for Siying Dong.


Changes
-------

Fix the unit test errors. 
They are all parsing errors. 


Summary
-------

Implement ALTER TABLE PARTITION RENAME function to rename a partition. 
Add HiveQL syntax "ALTER TABLE bar PARTITION (k1='v1', k2='v2') RENAME TO 
PARTITION (k1='v3', k2='v4');"
This is my first Hive diff, I just learn everything from existing codebase and 
may not have a good understanding on it. 
Feel free to inform me if I make something wrong. Thanks


This addresses bug HIVE-2247.
    https://issues.apache.org/jira/browse/HIVE-2247


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1186991 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1186991 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1186991 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1186991 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1186991 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1186991 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1186991 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1186991 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1186991 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 
1186991 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1186991 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1186991 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1186991 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1186991 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
1186991 
  
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1186991 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1186991 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/RenamePartitionDesc.java 
PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/alter_rename_partition_failure.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/alter_rename_partition_failure2.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/alter_rename_partition_failure3.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/alter_rename_partition.q 
PRE-CREATION 
  
trunk/ql/src/test/queries/clientpositive/alter_rename_partition_authorization.q 
PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out 
PRE-CREATION 
  
trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out 
PRE-CREATION 
  
trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out 
PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/alter_rename_partition.q.out 
PRE-CREATION 
  
trunk/ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/1105/diff


Testing
-------

Add a partition A in the table
Rename partition A to partition B
Show the partitions in the table, it returns partition B.
SELECT the data from partition A, it returns no results
SELECT the data from partition B, it returns the data originally stored in 
partition A


Thanks,

Weiyan


                
> ALTER TABLE RENAME PARTITION
> ----------------------------
>
>                 Key: HIVE-2247
>                 URL: https://issues.apache.org/jira/browse/HIVE-2247
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Siying Dong
>            Assignee: Weiyan Wang
>         Attachments: HIVE-2247.10.patch.txt, HIVE-2247.3.patch.txt, 
> HIVE-2247.4.patch.txt, HIVE-2247.5.patch.txt, HIVE-2247.6.patch.txt, 
> HIVE-2247.7.patch.txt, HIVE-2247.8.patch.txt, HIVE-2247.9.patch.txt, 
> HIVE-2247.9.patch.txt
>
>
> We need a ALTER TABLE TABLE RENAME PARTITIONfunction that is similar t ALTER 
> TABLE RENAME.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to