[
https://issues.apache.org/jira/browse/HIVE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146867#comment-13146867
]
jirapos...@reviews.apache.org commented on HIVE-2247:
-----------------------------------------------------
bq. On 2011-11-09 08:48:57, Kevin Wilfong wrote:
bq. > I'll review this, but you should add another reviewer, like Siying, who
has the authority to commit to Hive, as I do not.
bq.
bq. Kevin Wilfong wrote:
bq. As long as you're modifying fields, you should add hive to the Groups
field and HIVE-2247 in the Bugs field.
Sorry, I thought HIVE-2247 was the JIRA this review was for, it should really
be HIVE-2562 in the bugs field, that way everything that gets posted here will
get posted on the JIRA as well. Thanks for making these changes.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3125
-----------------------------------------------------------
On 2011-11-09 08:58:03, Weiyan Wang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2783/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-09 08:58:03)
bq.
bq.
bq. Review request for hive, Siying Dong and Kevin Wilfong.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. keep the old api alter_partition, and add the new api
alter_rename_partition. In the server side, alter_partition calls
alter_rename_partition with part_vals = null
bq.
bq. Run the "ant test". Only load_fs.q fails, but after I revert the patch and
run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q
-Dtest.silent=false" it still fails. So I think it's not a bug introduced by my
patch
bq.
bq.
bq. This addresses bug HIVE-2247.
bq. https://issues.apache.org/jira/browse/HIVE-2247
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/metastore/if/hive_metastore.thrift 1199598
bq. trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598
bq. trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598
bq.
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
1199598
bq.
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1199598
bq.
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
1199598
bq.
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
1199598
bq.
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
1199598
bq. trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1199598
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1199598
bq.
bq. Diff: https://reviews.apache.org/r/2783/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Weiyan
bq.
bq.
> ALTER TABLE RENAME PARTITION
> ----------------------------
>
> Key: HIVE-2247
> URL: https://issues.apache.org/jira/browse/HIVE-2247
> Project: Hive
> Issue Type: New Feature
> Reporter: Siying Dong
> Assignee: Weiyan Wang
> Attachments: HIVE-2247.10.patch.txt, HIVE-2247.11.patch.txt,
> HIVE-2247.3.patch.txt, HIVE-2247.4.patch.txt, HIVE-2247.5.patch.txt,
> HIVE-2247.6.patch.txt, HIVE-2247.7.patch.txt, HIVE-2247.8.patch.txt,
> HIVE-2247.9.patch.txt, HIVE-2247.9.patch.txt
>
>
> We need a ALTER TABLE TABLE RENAME PARTITIONfunction that is similar t ALTER
> TABLE RENAME.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
