-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37925/#review97617
-----------------------------------------------------------



metastore/if/hive_metastore.thrift (line 990)
<https://reviews.apache.org/r/37925/#comment153633>

    Is max_parts required in this api?



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
(line 828)
<https://reviews.apache.org/r/37925/#comment153635>

    Can you avoid doing indentation changes in code that is not touched ?


- Amareshwari Sriramadasu


On Sept. 2, 2015, 11:14 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37925/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 11:14 a.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-11487
>     https://issues.apache.org/jira/browse/HIVE-11487
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Adding api for getting number of partitions for a filter. In order to be more 
> optimal when only interested in the number. getAllPartitions will construct 
> all the partition object which can be time consuming and not required.
> 
> 
> Diffs
> -----
> 
>   metastore/if/hive_metastore.thrift d651195e0477ee607657fec13b68ff3184ddbebf 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 1840e76cc567e95e1942d912b8ab0db516d63a3b 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> 482f27851c0732604cdb04e9a0b981757643210b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> 5fde6d34bff7fd091b3ca36472d929269660c9b9 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> 522fcc275f42a3b75af9f4bee9bf1ab3cd70364b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> d165fc82386eafa5200068f5c56a9e98788627aa 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
> 7c85eea21375f349f88e918329030364acca2771 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  f184c568b5eb5b16f239c6128f1ad20bd83957cb 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  83fb4bb900a51101d8c411d199357c8ddd29486e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
> 396c07044ec69d8b74e38fb156333b6eb35b9f4d 
> 
> Diff: https://reviews.apache.org/r/37925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>

Reply via email to