> On Sept. 2, 2015, 7:36 p.m., Sergey Shelukhin wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line > > 2601 > > <https://reviews.apache.org/r/37925/diff/3/?file=1062214#file1062214line2601> > > > > that doesn't seem efficient. It just returns a list and then takes size.
Using count on PART_ID now to get number of partitions. Changes made for directsql. For JDO it still getting the list and doing size() on it. > On Sept. 2, 2015, 7:36 p.m., Sergey Shelukhin wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, > > line 854 > > <https://reviews.apache.org/r/37925/diff/3/?file=1062213#file1062213line854> > > > > btw, why not use COUNT in the query in the first place > > Amareshwari Sriramadasu wrote: > I agree with Sergey, we should try count() instead of getting partition > ids and doing a size on that. Makes sense. Updated. - Akshay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37925/#review97519 ----------------------------------------------------------- On Sept. 14, 2015, 8:05 a.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37925/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 8:05 a.m.) > > > Review request for hive and Amareshwari Sriramadasu. > > > Bugs: HIVE-11487 > https://issues.apache.org/jira/browse/HIVE-11487 > > > Repository: hive-git > > > Description > ------- > > Adding api for getting number of partitions for a filter. In order to be more > optimal when only interested in the number. getAllPartitions will construct > all the partition object which can be time consuming and not required. > > > Diffs > ----- > > metastore/if/hive_metastore.thrift d651195e0477ee607657fec13b68ff3184ddbebf > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1840e76cc567e95e1942d912b8ab0db516d63a3b > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 482f27851c0732604cdb04e9a0b981757643210b > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 5fde6d34bff7fd091b3ca36472d929269660c9b9 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 1f89b7c83299d8345722ae21267151a11676c332 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 4d6bfccbd1164fd22ed1c4592c3f227d8182936f > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java > 7c85eea21375f349f88e918329030364acca2771 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > f184c568b5eb5b16f239c6128f1ad20bd83957cb > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 83fb4bb900a51101d8c411d199357c8ddd29486e > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > a4f9f6cee2c7aeb1235a814fdb06e75d37809424 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > c78e8f474f928c77a45ff29134054d43184f0324 > > Diff: https://reviews.apache.org/r/37925/diff/ > > > Testing > ------- > > > Thanks, > > Akshay Goyal > >
