> On Oct. 7, 2015, 6:21 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 377 > > <https://reviews.apache.org/r/37778/diff/7/?file=1088802#file1088802line377> > > > > 1. We shouldn't remove non deterministic UDFs. > > 2. Also make sure that partitionPruner isn't considering non > > deterministic UDFs > > 3. Please add testcase that involves non deterministic udf > > 4. Add a test case involving conditional expressions (case, If..) > > Ex: select key from t1 where (case when key=1 then 10 else 20 end) in > > (10,11);
Thanks for reviewing the patch, John 1, 3, 4. Done in the new patch 2. Verified in the existing code base - Hari Sankar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review101804 ----------------------------------------------------------- On Oct. 7, 2015, 7:47 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37778/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 7:47 p.m.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John > Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Support partition pruning for IN(STRUCT(partcol, nonpartcol..)...) > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 54a529e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 439f616 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java > d83636d > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java > 825938a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java > 7262164 > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 6a31689 > ql/src/test/queries/clientpositive/pcs.q PRE-CREATION > ql/src/test/queries/clientpositive/pointlookup.q 1aef2ef > ql/src/test/queries/clientpositive/pointlookup2.q 31bebbb > ql/src/test/queries/clientpositive/pointlookup3.q 3daa94b > ql/src/test/results/clientpositive/dynpart_sort_optimization_acid.q.out > eca29df > ql/src/test/results/clientpositive/pcs.q.out PRE-CREATION > ql/src/test/results/clientpositive/pointlookup.q.out 7e19be4 > ql/src/test/results/clientpositive/pointlookup2.q.out 55edd90 > ql/src/test/results/clientpositive/pointlookup3.q.out 4cfb97e > > Diff: https://reviews.apache.org/r/37778/diff/ > > > Testing > ------- > > Local testing done. More unit tests coming in the next patch. > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
