-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37778/#review101814
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java 
(line 385)
<https://reviews.apache.org/r/37778/#comment159310>

    Add unit test cases for:
    1. DNF(CNF)
    expr1 or expr2 (where expr2 is conjuctine tree)
    2. In clause involving part/non-part col that are combined by disjunction


- John Pullokkaran


On Oct. 7, 2015, 7:47 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37778/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 7:47 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John 
> Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support partition pruning for IN(STRUCT(partcol, nonpartcol..)...)
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 54a529e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 439f616 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java
>  PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java 
> d83636d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java 
> 825938a 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java 
> 7262164 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 6a31689 
>   ql/src/test/queries/clientpositive/pcs.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/pointlookup.q 1aef2ef 
>   ql/src/test/queries/clientpositive/pointlookup2.q 31bebbb 
>   ql/src/test/queries/clientpositive/pointlookup3.q 3daa94b 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization_acid.q.out 
> eca29df 
>   ql/src/test/results/clientpositive/pcs.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/pointlookup.q.out 7e19be4 
>   ql/src/test/results/clientpositive/pointlookup2.q.out 55edd90 
>   ql/src/test/results/clientpositive/pointlookup3.q.out 4cfb97e 
> 
> Diff: https://reviews.apache.org/r/37778/diff/
> 
> 
> Testing
> -------
> 
> Local testing done. More unit tests coming in the next patch.
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Reply via email to