> On Nov. 24, 2015, 3:56 a.m., Siddharth Seth wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2361 > > <https://reviews.apache.org/r/40315/diff/2/?file=1127510#file1127510line2361> > > > > Don't think the default value - "*" - has any significance here. > > Replace by null - to avoid confusion. > > Sergey Shelukhin wrote: > Following in the footsteps of slider > > Siddharth Seth wrote: > Can we drop the * in favor of a null. (or no default if Hive supports > that).
Why? > On Nov. 24, 2015, 3:56 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolClientImpl.java, > > line 129 > > <https://reviews.apache.org/r/40315/diff/2/?file=1127516#file1127516line129> > > > > This could be moved into it's own protocol (but listening on the same > > server). > > > > The methods so far are for access from the AM. > > > > getTokens is to be used by Clients. > > > > What that also allows is for the annotations to change. > > getTokens() - protected by Kerberos, and cannot be obtained using a > > token. > > Remaining methods - require a token. > > Sergey Shelukhin wrote: > why add an extra protocol? it seems like most services don't handle > tokens like this. HDFS gives out tokens as part of normal interface. > > Siddharth Seth wrote: > HDFS also doesn't have a separation of API vs server side jars. > > Reason for separation is that they're very different operations - one > relates to exuecuting and tracking work, the other to access. Consider the > case where there is a central service which is responsible for handing out > these delegation tokens (rotation, etc etc). That will definitely not > implement the submitWork APIs, and the daemons cannot implement the getTokns > at that point. > > Doesn't need to be done rightnow, and can be changed later since this API > is private for the moment (It is private, right?) > > Re-opened primarily for the "Is this private" bit. Added new protocol. Will test after the weekend. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review107706 ----------------------------------------------------------- On Nov. 24, 2015, 11:11 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40315/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 11:11 p.m.) > > > Review request for hive, Gopal V and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fffedd9 > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIoProxy.java > 4c31e32 > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapDaemonProtocolBlockingPB.java > 5ad2344 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 98b1ccd > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolClientImpl.java > 4b13277 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolServerImpl.java > 784c631 > > llap-server/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java > fae7654 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapDaemonPolicyProvider.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapServerSecurityInfo.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapTokenSelector.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java > d327fc0 > > llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapUmbilicalPolicyProvider.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java > 33e998c > > llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo > PRE-CREATION > llap-server/src/protobuf/LlapDaemonProtocol.proto 0ba6acf > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java > 8d45c95 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a210b95 > ql/src/java/org/apache/hadoop/hive/ql/exec/GlobalWorkMapFactory.java > 59ee347 > ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheFactory.java 3d9771a > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java > 914b4e7 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java > efcf88c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 07f26be > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3feab1a > serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java 9269ff4 > > Diff: https://reviews.apache.org/r/40315/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
