-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40315/#review108296
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2357 - 2358)
<https://reviews.apache.org/r/40315/#comment167688>

    Spell out ZooKeeper in the description.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2359 - 2361)
<https://reviews.apache.org/r/40315/#comment167689>

    Spell out ZooKeeper in the description.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2362 - 2363)
<https://reviews.apache.org/r/40315/#comment167692>

    Spell out ZooKeeper in the description.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2367 - 2368)
<https://reviews.apache.org/r/40315/#comment167690>

    Should this have a TimeValidator (like the next two Spark parameters, lines 
2372-2376)?
    
    Also, the default is 14 * 24 * 3600 but the comment says 
DelegationTokenManager default is 1 week instead of 2 weeks, so is 
DelegationTokenManager something different from this parameter?


- Lefty Leverenz


On Nov. 26, 2015, 1:38 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40315/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 1:38 a.m.)
> 
> 
> Review request for hive, Gopal V and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java db942b0 
>   llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIoProxy.java 
> 4c31e32 
>   llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java 
> PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java
>  PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapDaemonProtocolBlockingPB.java
>  5ad2344 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapManagementProtocolBlockingPB.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
> 98b1ccd 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolClientImpl.java
>  4b13277 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolServerImpl.java
>  784c631 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapManagementProtocolClientImpl.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java
>  fae7654 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapDaemonPolicyProvider.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapServerSecurityInfo.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapTokenSelector.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java 
> PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
>  d327fc0 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapUmbilicalPolicyProvider.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java
>  33e998c 
>   
> llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
>  PRE-CREATION 
>   
> llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.token.TokenRenewer
>  PRE-CREATION 
>   llap-server/src/protobuf/LlapDaemonProtocol.proto 0ba6acf 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 
> 4525ab9 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
>  8d45c95 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a210b95 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/GlobalWorkMapFactory.java 
> 59ee347 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheFactory.java 3d9771a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java 
> 914b4e7 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java 
> efcf88c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 07f26be 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3feab1a 
>   serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java 9269ff4 
> 
> Diff: https://reviews.apache.org/r/40315/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Reply via email to