----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41297/#review111650 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java (line 267) <https://reviews.apache.org/r/41297/#comment171861> It may be better to remove toStringTree and replace it with toLowerStringTree. Since in Hive all col names, udf/udaf are case insensitive, we might be ok if we make only literals case sensitive. - John Pullokkaran On Dec. 17, 2015, 6:36 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41297/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 6:36 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-12590 > https://issues.apache.org/jira/browse/HIVE-12590 > > > Repository: hive-git > > > Description > ------- > > Repeated UDAFs with literals can produce incorrect result > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java b96e2eb > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 891b1f7 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 27549dc > ql/src/test/queries/clientpositive/groupby_duplicate_key.q 7f38efe > ql/src/test/results/clientpositive/groupby_duplicate_key.q.out fc95f41 > > Diff: https://reviews.apache.org/r/41297/diff/ > > > Testing > ------- > > Added new test > > > Thanks, > > Ashutosh Chauhan > >
