-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41297/#review113329
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java (line 245)
<https://reviews.apache.org/r/41297/#comment173867>

    May be use a local var to store the str value; this way we could avoid 
duplicating logic at 2 places ?


- John Pullokkaran


On Jan. 7, 2016, 9:17 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41297/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 9:17 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-12590
>     https://issues.apache.org/jira/browse/HIVE-12590
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Repeated UDAFs with literals can produce incorrect result
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java b96e2eb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 891b1f7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ab9271f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
> 9d8b352 
>   ql/src/test/queries/clientpositive/groupby_duplicate_key.q 7f38efe 
>   ql/src/test/results/clientpositive/case_sensitivity.q.out a5b14e8 
>   ql/src/test/results/clientpositive/groupby_duplicate_key.q.out fc95f41 
>   
> ql/src/test/results/clientpositive/tez/schema_evol_orc_acid_mapwork_table.q.out
>  0317a99 
>   
> ql/src/test/results/clientpositive/tez/schema_evol_orc_acidvec_mapwork_table.q.out
>  3edaff0 
> 
> Diff: https://reviews.apache.org/r/41297/diff/
> 
> 
> Testing
> -------
> 
> Added new test
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>

Reply via email to