> On 1月 14, 2016, 5:36 p.m., Prasad Mujumdar wrote: > > service/if/TCLIService.thrift, line 272 > > <https://reviews.apache.org/r/40867/diff/4/?file=1187218#file1187218line272> > > > > Does it need to be a required parameter ? Adding a new required > > parameter in the middle will make it break the backward compatibility for > > existing clients. > > Takanobu Asanuma wrote: > Yes, it is necessary to be a required parameter since this patch had > TypeDescriptor created by the typename in ColumnDescriptor. (Please see last > Sergey's review.) Next patch fixes the order of the parameters. > > Sergey Shelukhin wrote: > if the new client sends the request to the old server, that is not going > to work... it needs to be optional and the code that gets it needs to work > around if it's absent - for example, it can just use the old path w/o bypass.
Sergey I understand. Thanks for the notice! - Takanobu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review114504 ----------------------------------------------------------- On 1月 25, 2016, 9:25 a.m., Takanobu Asanuma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40867/ > ----------------------------------------------------------- > > (Updated 1月 25, 2016, 9:25 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This is a WIP patch for HIVE-11527 > > * I added a new configuration whose name is > hive.server2.webhdfs.bypass.enabled. The default is false. When this value is > true, clients use the bypass. > > * I still have not considered security such as Kerberos and SSL at present. > > * I have not implement Statement#setFetchSize for bypass yet. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a44e75a > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 75187cf > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 0b0c336 > service-rpc/if/TCLIService.thrift 0aa9d13 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 5364293 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b7 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java > 31472c8 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java > 7101fa5 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java > 14d50ed > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f5 > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec4 > service/src/java/org/apache/hive/service/cli/CLIService.java 0d5ae1e > service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 113eddf > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 92135cd > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > c8a69b9 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 4f4e92d > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 3c5700b > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 78b4b31 > > Diff: https://reviews.apache.org/r/40867/diff/ > > > Testing > ------- > > I have tested few simple queries and they worked well. But I think there are > some problems for some queries. I'm going to test more queries and fix bugs. > I'm also going to add unit tests. > > > Thanks, > > Takanobu Asanuma > >
