----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review130014 -----------------------------------------------------------
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 557) <https://reviews.apache.org/r/40867/#comment193626> nit: is it enough to just use Arrays.asList? jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 580) <https://reviews.apache.org/r/40867/#comment193630> why does this swallow the error? It should fail on error jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 581) <https://reviews.apache.org/r/40867/#comment193629> nit: null check, there could be an error before stream is created - Sergey Shelukhin On April 15, 2016, 11:38 a.m., Takanobu Asanuma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40867/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 11:38 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This is a WIP patch for HIVE-11527 > > * I added a new configuration whose name is > hive.server2.webhdfs.bypass.enabled. The default is false. When this value is > true, clients use the bypass. > > * I still have not considered security such as Kerberos and SSL at present. > > * I have not implement Statement#setFetchSize for bypass yet. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c7e5b33 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java > 84644d1 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 857805a > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java > 637e51a > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 0bbd0e3 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 92c2c76 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 0b0c336 > service-rpc/if/TCLIService.thrift aa28b6e > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java > 31472c8 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java > 7101fa5 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java > 1aa3f94 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java > 14d50ed > service-rpc/src/gen/thrift/gen-php/Types.php b7df50a > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781 > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c > service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2 > service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > b7d6549 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 56a9c18 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 9ce6055 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 4f4e92d > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 0f36cd6 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > be9833d > > Diff: https://reviews.apache.org/r/40867/diff/ > > > Testing > ------- > > I have tested few simple queries and they worked well. But I think there are > some problems for some queries. I'm going to test more queries and fix bugs. > I'm also going to add unit tests. > > > Thanks, > > Takanobu Asanuma > >