----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44271/#review121974 -----------------------------------------------------------
Conceptually patch looks good, but had the following question below. service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java (line 127) <https://reviews.apache.org/r/44271/#comment183830> I'm a bit afraid of concurrency issues by caching Hive. There seems to be quite some issues with Hive object lately and multi-threading and caching seems discouraged now (see HIVE-13002, HIVE-13194, HIVE-13150) Can we have DbTokenStore get Hive on demand via thread-local when it needs it, say if hmsHandler is not passed in? And also can you double-check if it will not leak, ie Hive object is closed somehow by the thread once its done? - Szehon Ho On March 2, 2016, 4:39 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44271/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 4:39 p.m.) > > > Review request for hive. > > > Bugs: HIVE-12270 > https://issues.apache.org/jira/browse/HIVE-12270 > > > Repository: hive-git > > > Description > ------- > > Add HMS APIs to support DB delegation token in HS2. > Only upload the patch without other thrift generated files for review here. > > > Diffs > ----- > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/MiniHiveKdc.java > dedbf35 > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithDBTokenStore.java > PRE-CREATION > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java > 3ef2ce3 > metastore/if/hive_metastore.thrift e8f0a68 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > bfebfdc > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > b5c4d1d > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > cb092d1 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 0c7455d > shims/common/src/main/java/org/apache/hadoop/hive/thrift/DBTokenStore.java > de39d3d > > Diff: https://reviews.apache.org/r/44271/diff/ > > > Testing > ------- > > Manuall tests > New Unit test TestJdbcWithDBToken > Precommit tests > > > Thanks, > > Chaoyu Tang > >
