----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44271/#review122019 -----------------------------------------------------------
Yea I studied the code a little bit after our discussion, seems like if we just use raw MSC like I suggest then we wil never close it if DbTokenStore is invoked by thrift threads.. whereas Hive object does have a static close call later in the thread's life. So let's go with the previous patch, it sucks to have to cache and pass the Hive object as its designed to be thread-local, but it's better than risking HMS leaks. Sorry for the long discussion with you about it. - Szehon Ho On March 4, 2016, 3:24 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44271/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 3:24 a.m.) > > > Review request for hive. > > > Bugs: HIVE-12270 > https://issues.apache.org/jira/browse/HIVE-12270 > > > Repository: hive-git > > > Description > ------- > > Add HMS APIs to support DB delegation token in HS2. > Only upload the patch without other thrift generated files for review here. > > > Diffs > ----- > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/MiniHiveKdc.java > dedbf35 > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithDBTokenStore.java > PRE-CREATION > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java > 3ef2ce3 > metastore/if/hive_metastore.thrift e8f0a68 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > bfebfdc > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > b5c4d1d > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > cb092d1 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 0c7455d > shims/common/src/main/java/org/apache/hadoop/hive/thrift/DBTokenStore.java > de39d3d > > Diff: https://reviews.apache.org/r/44271/diff/ > > > Testing > ------- > > Manuall tests > New Unit test TestJdbcWithDBToken > Precommit tests > > > Thanks, > > Chaoyu Tang > >
