[
https://issues.apache.org/jira/browse/HIVE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145713#comment-13145713
]
jirapos...@reviews.apache.org commented on HIVE-2553:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2733/#review3079
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java
<https://reviews.apache.org/r/2733/#comment6866>
One of Hive's coding style is variable should be defined as interface (Set)
rather than implementation (HashSet).
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java
<https://reviews.apache.org/r/2733/#comment6867>
Please add a comment on why starting from index 1, and your assumption that
this function should only be called when the ObjectInspect is for primitive
types.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java
<https://reviews.apache.org/r/2733/#comment6886>
Please take a look at constant OI (HIVE-1360) and see if it applies here.
- Ning
On 2011-11-05 03:02:38, Robert Surówka wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2733/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-05 03:02:38)
bq.
bq.
bq. Review request for Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Introduction of Hashing for IN operator for primitive types
bq.
bq.
bq. This addresses bug HIVE-2553.
bq. https://issues.apache.org/jira/browse/HIVE-2553
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java
1197870
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java
1197870
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/StructTypeInfo.java
1197870
bq.
bq. Diff: https://reviews.apache.org/r/2733/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Worked on some sample queries
bq.
bq.
bq. Thanks,
bq.
bq. Robert
bq.
bq.
> Use hashing instead of list traversal for IN operator for primitive types
> -------------------------------------------------------------------------
>
> Key: HIVE-2553
> URL: https://issues.apache.org/jira/browse/HIVE-2553
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Minor
> Attachments: HIVE-2553.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
