[ https://issues.apache.org/jira/browse/HIVE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146808#comment-13146808 ]
jirapos...@reviews.apache.org commented on HIVE-2553: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2733/#review3123 ----------------------------------------------------------- trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java <https://reviews.apache.org/r/2733/#comment6938> Can you confirm if ConstantObjectInspector is supported by all non-primitive types? Also it would be nice to add more unit tests for cases where IN() take parameters of list of all supported primitive constants. - Ning On 2011-11-08 18:03:51, Robert Surówka wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2733/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-11-08 18:03:51) bq. bq. bq. Review request for Ning Zhang. bq. bq. bq. Summary bq. ------- bq. bq. Introduction of Hashing for IN operator for constant values bq. bq. bq. This addresses bug HIVE-2553. bq. https://issues.apache.org/jira/browse/HIVE-2553 bq. bq. bq. Diffs bq. ----- bq. bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1199066 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java 1199066 bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/StructTypeInfo.java 1199066 bq. bq. Diff: https://reviews.apache.org/r/2733/diff bq. bq. bq. Testing bq. ------- bq. bq. Worked on some sample queries bq. bq. bq. Thanks, bq. bq. Robert bq. bq. > Use hashing instead of list traversal for IN operator for primitive types > ------------------------------------------------------------------------- > > Key: HIVE-2553 > URL: https://issues.apache.org/jira/browse/HIVE-2553 > Project: Hive > Issue Type: Improvement > Reporter: Robert Surówka > Assignee: Robert Surówka > Priority: Minor > Attachments: HIVE-2553.1.patch, HIVE-2553.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira