----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review130230 -----------------------------------------------------------
Mostly looks good. Left some comments - mostly minor issues. The one about the Configuration being used only in HS2 I think would be useful to fix. llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java (line 73) <https://reviews.apache.org/r/46579/#comment193938> Minor: static class llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java (line 156) <https://reviews.apache.org/r/46579/#comment193939> Minor: static class llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java (line 166) <https://reviews.apache.org/r/46579/#comment193940> Either here, or when constructing the Impl - a log line indicating where the token is being fetched from will be useful - similar to the one in RemoteImpl. llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java (line 168) <https://reviews.apache.org/r/46579/#comment193941> Can we restrict this configuration parameter to be used within HS2 only ? Any other client (CLI) would have it off by default - and fetch the token from LLAP itself. me - Siddharth Seth On April 22, 2016, 6:47 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46579/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 6:47 p.m.) > > > Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit > Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fabb8ab > llap-common/src/java/org/apache/hadoop/hive/llap/LlapUtil.java ce03de0 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > e99e689 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > 76ba225 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 8c7a539 > > Diff: https://reviews.apache.org/r/46579/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >