> On April 23, 2016, 12:38 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java, > > line 193 > > <https://reviews.apache.org/r/46579/diff/1/?file=1357677#file1357677line193> > > > > Can we restrict this configuration parameter to be used within HS2 only > > ? > > Any other client (CLI) would have it off by default - and fetch the > > token from LLAP itself. > > Siddharth Seth wrote: > Also. the config property name will likely need a rename if this is > restricted to HS2.
changed to have both options - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review130230 ----------------------------------------------------------- On April 22, 2016, 6:47 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46579/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 6:47 p.m.) > > > Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit > Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fabb8ab > llap-common/src/java/org/apache/hadoop/hive/llap/LlapUtil.java ce03de0 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > e99e689 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > 76ba225 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 8c7a539 > > Diff: https://reviews.apache.org/r/46579/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
