----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/#review142839 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (line 1200) <https://reviews.apache.org/r/49965/#comment208512> Can you add a comment here saying partNames = null means all partitions. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (line 1212) <https://reviews.apache.org/r/49965/#comment208513> This needs to be revisited. Can you leave an appropriate TODO here. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (lines 1255 - 1258) <https://reviews.apache.org/r/49965/#comment208514> I don't think this null check is needed. ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java (line 394) <https://reviews.apache.org/r/49965/#comment208510> Is this needed? ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java (lines 69 - 71) <https://reviews.apache.org/r/49965/#comment208511> Is this needed? ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java (line 310) <https://reviews.apache.org/r/49965/#comment208520> getPartsFound() should be set correctly from server and this means this logic can be improved here. - Ashutosh Chauhan On July 19, 2016, 9:19 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49965/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 9:19 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Hive generates inefficient metastore queries for TPCDS tables with 1800+ > partitions leading to higher compile time > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 38c0eed > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 909d8eb > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 9c900af > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 26e936e > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > da2e1e2 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 > > Diff: https://reviews.apache.org/r/49965/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
