> On July 19, 2016, 9:40 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, > > lines 1255-1258 > > <https://reviews.apache.org/r/49965/diff/3/?file=1447530#file1447530line1255> > > > > I don't think this null check is needed.
Ok, noticed we wont hit this code if partNames is null. > On July 19, 2016, 9:40 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java, line 310 > > <https://reviews.apache.org/r/49965/diff/3/?file=1447533#file1447533line310> > > > > getPartsFound() should be set correctly from server and this means this > > logic can be improved here. In the case where partNames = null, does it not mean that we have retrieved column stats for all the partitions and hence not set the colState to State.PARTIAL. - Hari Sankar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/#review142839 ----------------------------------------------------------- On July 19, 2016, 9:19 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49965/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 9:19 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Hive generates inefficient metastore queries for TPCDS tables with 1800+ > partitions leading to higher compile time > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 38c0eed > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 909d8eb > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 9c900af > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 26e936e > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > da2e1e2 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 > > Diff: https://reviews.apache.org/r/49965/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
