----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152686 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 115) <https://reviews.apache.org/r/52835/#comment221771> Does the autoCommit false work for DDLs? As far as I know, some RDBMS and their drivers might not, and DDLs commit automatically regardless. Most sqls in HMS upgrade scripts are DDLs (e.g. alter table etc), so this patch might not work as expected. - Chaoyu Tang On Oct. 13, 2016, 8:43 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52835/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 8:43 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 181f0d2 > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java cd36ddf > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java > 0d5f9c8 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 9c30ee7 > > Diff: https://reviews.apache.org/r/52835/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
