> On Oct. 14, 2016, 3:38 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 123 > > <https://reviews.apache.org/r/52835/diff/2/?file=1535139#file1535139line123> > > > > I verified against derby and it works fine. > > > > Let me verify other databases. Seems as you said, some databases like > > mysql may have such issues.
OK. That seems to be a problem. It won't work as expected for some databases. - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152688 ----------------------------------------------------------- On Oct. 13, 2016, 8:43 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52835/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 8:43 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 181f0d2 > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java cd36ddf > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java > 0d5f9c8 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 9c30ee7 > > Diff: https://reviews.apache.org/r/52835/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >