----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52981/#review153059 -----------------------------------------------------------
Thank you for the patch Jianguo Tian. LGTM, pending tests. Hope you don't mind that I had a look as well. beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java (line 559) <https://reviews.apache.org/r/52981/#comment222335> nit: extra spaces beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java (line 567) <https://reviews.apache.org/r/52981/#comment222336> nit: extra spaces beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java (line 104) <https://reviews.apache.org/r/52981/#comment222337> I think we can remove this line, not just comment it out. (Same for line 36). beeline/src/main/resources/BeeLine.properties (line 190) <https://reviews.apache.org/r/52981/#comment222334> Missing verb in the sentence. will not be visible around a value? or will not be present around a value? - Barna Zsombor Klara On Oct. 18, 2016, 8:11 a.m., Jianguo Tian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52981/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 8:11 a.m.) > > > Review request for hive and cheng xu. > > > Bugs: HIVE-14679 > https://issues.apache.org/jira/browse/HIVE-14679 > > > Repository: hive-git > > > Description > ------- > > 1. Quoting should be enabled by default for csv2, tsv2 and dsv. > 2. Disabling quoting should be possible using a beeline argument. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 79922d2 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 57b9c46 > beeline/src/java/org/apache/hive/beeline/Commands.java 039e354 > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java > 66d9fd0 > beeline/src/main/resources/BeeLine.properties ad79c01 > > Diff: https://reviews.apache.org/r/52981/diff/ > > > Testing > ------- > > > Thanks, > > Jianguo Tian > >
