----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52981/#review153339 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/Commands.java (line 650) <https://reviews.apache.org/r/52981/#comment222631> No space needed after set. beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java (line 105) <https://reviews.apache.org/r/52981/#comment222634> Why default value is true? beeline/src/main/resources/BeeLine.properties (line 190) <https://reviews.apache.org/r/52981/#comment222635> If this option is not applicable for all outputformat, can you please make it clear what kind of outputformat the options can be applied? beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 48) <https://reviews.apache.org/r/52981/#comment222639> Please add a test like ""value"" beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 69) <https://reviews.apache.org/r/52981/#comment222642> AFAIK, this option doesn't affect csv/tsv/dsv. So you can see no change after enabling it. Please remove them if my understanding is correct. beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 115) <https://reviews.apache.org/r/52981/#comment222638> I am not sure why default value is true. If the default value is true, no need to set it again here. And we should test the case when quoting is disabled. beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 182) <https://reviews.apache.org/r/52981/#comment222641> hint: is that possible to reuse the code in TestBufferedRows? beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 217) <https://reviews.apache.org/r/52981/#comment222637> Remove this line please. - cheng xu On Oct. 19, 2016, 7:55 p.m., Jianguo Tian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52981/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 7:55 p.m.) > > > Review request for hive and cheng xu. > > > Bugs: HIVE-14679 > https://issues.apache.org/jira/browse/HIVE-14679 > > > Repository: hive-git > > > Description > ------- > > 1. Quoting should be enabled by default for csv2, tsv2 and dsv. > 2. Disabling quoting should be possible using a beeline argument. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 79922d2 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 57b9c46 > beeline/src/java/org/apache/hive/beeline/Commands.java 039e354 > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java > 66d9fd0 > beeline/src/main/resources/BeeLine.properties ad79c01 > beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52981/diff/ > > > Testing > ------- > > Test csv2,tsv2,dsv,csv and tsv output format with enabling double quotes. > > > Thanks, > > Jianguo Tian > >
