----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/#review163222 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java (line 2211) <https://reviews.apache.org/r/55994/#comment234682> Yeah feels like this was suppose to use `jobConf` instead of `myJobConf` ql/src/test/org/apache/hadoop/hive/ql/exec/InputEstimatorTestClass.java (line 40) <https://reviews.apache.org/r/55994/#comment234683> Is this necessary? ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java (line 31) <https://reviews.apache.org/r/55994/#comment234684> nit: remove the `.*` same with ones below. ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java (line 363) <https://reviews.apache.org/r/55994/#comment234685> Do these need to be so high? My understanding is that this will create 100 folders? Can it just be something smaller like 5? - Sahil Takiar On Jan. 26, 2017, 8:09 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55994/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 8:09 p.m.) > > > Review request for hive, Mohit Sabharwal, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-15736 > https://issues.apache.org/jira/browse/HIVE-15736 > > > Repository: hive-git > > > Description > ------- > > Added unit tests on TestUtilities to validate > - Single and multiple threads > - InputEstimator usage > - ContentSummaryInputFormat usage. > > It also fixed an issue with the InputEstimator scenario where the values > returned by the InputEstimator where overriden later by the correct > filesystem calls. > > An interesting thing (code commented while it is on review) is that when > executing the InputEstimator code path the line commented seems are not > needed. It might > be that the idea was to set some configurations to the jobConf, but the > jobConf was never passed as parameter to the estimate method. Please help me > verify this. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > 68dd5e7247415dec1e353010ea34481c4f2fc6cd > ql/src/test/org/apache/hadoop/hive/ql/exec/InputEstimatorTestClass.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java > e444946e990d9adb90ce24837cfe4edcf5126d3a > > Diff: https://reviews.apache.org/r/55994/diff/ > > > Testing > ------- > > Waiting for tests HiveQA > > > Thanks, > > Sergio Pena > >
