----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/ -----------------------------------------------------------
(Updated Jan. 30, 2017, 8:48 p.m.) Review request for hive, Mohit Sabharwal, Sahil Takiar, and Vihang Karajgaonkar. Changes ------- Sahil, I left the Hive.get() without the false parameter. I got the errors when debugging, but when running the tests normally, then Hive was failing on direct-sql and it falls back to datanucleus to initialize and load the functions. So, now the tests are good again. Peter, I modified the lines to make them smaller. I still think keeping them to 100 characters is not necessary with today's monitor resolutions. Even IntelliJ gives you a larger number (120 chars) if you want to limit the line chars. Bugs: HIVE-15736 https://issues.apache.org/jira/browse/HIVE-15736 Repository: hive-git Description ------- Added unit tests on TestUtilities to validate - Single and multiple threads - InputEstimator usage - ContentSummaryInputFormat usage. It also fixed an issue with the InputEstimator scenario where the values returned by the InputEstimator where overriden later by the correct filesystem calls. An interesting thing (code commented while it is on review) is that when executing the InputEstimator code path the line commented seems are not needed. It might be that the idea was to set some configurations to the jobConf, but the jobConf was never passed as parameter to the estimate method. Please help me verify this. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 68dd5e7247415dec1e353010ea34481c4f2fc6cd ql/src/test/org/apache/hadoop/hive/ql/exec/InputEstimatorTestClass.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java e444946e990d9adb90ce24837cfe4edcf5126d3a Diff: https://reviews.apache.org/r/55994/diff/ Testing ------- Waiting for tests HiveQA Thanks, Sergio Pena