----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57518/#review168654 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 2815 (patched) <https://reviews.apache.org/r/57518/#comment240896> Is this needed? Having this check in genSelectLogicalPlan() should be sufficient? ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 3656 (patched) <https://reviews.apache.org/r/57518/#comment240898> This will never be ExprNodeColumnDesc, so should always be false. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 3710-3711 (patched) <https://reviews.apache.org/r/57518/#comment240899> commented code can be removed. ql/src/test/queries/clientpositive/subquery_select.q Lines 101 (patched) <https://reviews.apache.org/r/57518/#comment240915> Can you also add tests for not in and not exists? ql/src/test/results/clientpositive/llap/subquery_select.q.out Lines 19-24 (patched) <https://reviews.apache.org/r/57518/#comment240909> This plan is doing null counting for inner query for IN clause. I think this is unnecessary. - Ashutosh Chauhan On March 10, 2017, 6:32 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57518/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 6:32 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16091 > https://issues.apache.org/jira/browse/HIVE-16091 > > > Repository: hive-git > > > Description > ------- > > Support for subqueries in select statement (with limitations) > Wiki: https://cwiki.apache.org/confluence/display/Hive/Subqueries+in+SELECT > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties b01ebd8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java > b7b16b8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java > c1768f4 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java db8d46e > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java f0165dd > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 6c10704 > ql/src/test/queries/clientnegative/subquery_select_aggregate.q PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_complex_expr.q > PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_distinct.q PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_distinct2.q PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_udf.q PRE-CREATION > ql/src/test/queries/clientpositive/subquery_select.q PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_aggregate.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_complex_expr.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_distinct.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_distinct2.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_udf.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/subquery_select.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/57518/diff/1/ > > > Testing > ------- > > Added new tests > Done pre-commit testing > Pending: More tests > > > Thanks, > > Vineet Garg > >
