> On March 10, 2017, 7:46 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Lines 2815 (patched) > > <https://reviews.apache.org/r/57518/diff/1/?file=1661500#file1661500line2821> > > > > Is this needed? Having this check in genSelectLogicalPlan() should be > > sufficient?
This is needed since genGBLogicalPlan is called first and I remember for subqueries with distinct there was some issue and I had to add this check. Let me check and confirm this. > On March 10, 2017, 7:46 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/subquery_select.q.out > > Lines 19-24 (patched) > > <https://reviews.apache.org/r/57518/diff/1/?file=1661514#file1661514line19> > > > > This plan is doing null counting for inner query for IN clause. I think > > this is unnecessary. Since we care if IN returns true, false or NULL we need to know presence of NULL so doing count() is necessary. - Vineet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57518/#review168654 ----------------------------------------------------------- On March 14, 2017, 5:05 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57518/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 5:05 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16091 > https://issues.apache.org/jira/browse/HIVE-16091 > > > Repository: hive-git > > > Description > ------- > > Support for subqueries in select statement (with limitations) > Wiki: https://cwiki.apache.org/confluence/display/Hive/Subqueries+in+SELECT > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 2a7627a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java > b7b16b8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java > c1768f4 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java bf0a11b > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java f0165dd > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 6c10704 > ql/src/test/queries/clientnegative/subquery_in_select.q 1365389 > ql/src/test/queries/clientnegative/subquery_select_aggregate.q PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_complex_expr.q > PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_distinct.q PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_distinct2.q PRE-CREATION > ql/src/test/queries/clientnegative/subquery_select_udf.q PRE-CREATION > ql/src/test/queries/clientpositive/subquery_select.q PRE-CREATION > ql/src/test/results/clientnegative/subquery_in_select.q.out 5c69690 > ql/src/test/results/clientnegative/subquery_select_aggregate.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_distinct.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_distinct2.q.out > PRE-CREATION > ql/src/test/results/clientnegative/subquery_select_udf.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/subquery_select.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/57518/diff/3/ > > > Testing > ------- > > Added new tests > Done pre-commit testing > Pending: More tests > > > Thanks, > > Vineet Garg > >
