----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171125 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g Lines 590-592 (patched) <https://reviews.apache.org/r/58181/#comment244016> It will be good to not add extra tokens in grammar as it increases the size of state machine. How about: KW_IS (a=KW_NOT)? KW_DISTINCT KW_FROM -> {$a !=null}? ^(EQUAL_NS) -> ^(KW_NOT EQUAL_NS) - Ashutosh Chauhan On April 4, 2017, 11:05 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58181/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 11:05 p.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Bugs: HIVE-15986 > https://issues.apache.org/jira/browse/HIVE-15986 > > > Repository: hive-git > > > Description > ------- > > This patch adds support for 'is distinct from' and 'is not distinct from'. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 7a70c9c > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ccfb455 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 85450c9 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d98a663 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8c4ee8a > ql/src/test/queries/clientpositive/is_distinct_from.q PRE-CREATION > ql/src/test/results/clientpositive/llap/is_distinct_from.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/58181/diff/2/ > > > Testing > ------- > > Added new tests > Pre-commit testing > > > Thanks, > > Vineet Garg > >
