----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171760 -----------------------------------------------------------
ql/src/test/queries/clientpositive/is_distinct_from.q Lines 1 (patched) <https://reviews.apache.org/r/58181/#comment244770> Patch LGTM. It would be better if you can add more tests including column is distinct from column and also expr is distinct from expr, etc rather than only comparing constants. - pengcheng xiong On April 12, 2017, 12:14 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58181/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 12:14 a.m.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and > Pengcheng Xu. > > > Bugs: HIVE-15986 > https://issues.apache.org/jira/browse/HIVE-15986 > > > Repository: hive-git > > > Description > ------- > > This patch adds support for 'is distinct from' and 'is not distinct from'. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties fb85b9ece2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 85450c999f > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8c4ee8a38b > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > f979c1432e > ql/src/test/queries/clientpositive/is_distinct_from.q PRE-CREATION > ql/src/test/results/clientpositive/llap/is_distinct_from.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/58181/diff/5/ > > > Testing > ------- > > Added new tests > Pre-commit testing > > > Thanks, > > Vineet Garg > >
