-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60445/
-----------------------------------------------------------
Review request for hive and Sahil Takiar.
Bugs: HIVE-16935
https://issues.apache.org/jira/browse/HIVE-16935
Repository: hive-git
Description
-------
We strip sql comments from a command string. The stripped command is use to
determine which
CommandProcessor will execute the command. If the CommandProcessorFactory does
not select a special
CommandProcessor then we execute the original unstripped command so that the
sql parser can remove comments.
Move BeeLine's comment stripping code to HiveStringUtils and change BeeLine to
call it from there
Add a better test with separate tokens for "set role" in
TestCommandProcessorFactory.
Add a test case for comment removal in set_processor_namespaces.q using an
indented comment as
unindented comments are removed by the test driver.
Diffs
-----
beeline/src/java/org/apache/hive/beeline/Commands.java 3b2d72ed79
beeline/src/test/org/apache/hive/beeline/TestCommands.java 04c939a04c
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 27fd66d35e
common/src/java/org/apache/hive/common/util/HiveStringUtils.java 4a6413a7c3
common/src/test/org/apache/hive/common/util/TestHiveStringUtils.java
6bd7037152
ql/src/test/org/apache/hadoop/hive/ql/processors/TestCommandProcessorFactory.java
21bdcf4443
ql/src/test/queries/clientpositive/set_processor_namespaces.q 612807f0c8
ql/src/test/results/clientpositive/set_processor_namespaces.q.out c05ce4d61d
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
2dd90b69b3
Diff: https://reviews.apache.org/r/60445/diff/1/
Testing
-------
Added new test case.
Hand tested with Hue and Jdbc.
Thanks,
Andrew Sherman
