> On June 28, 2017, 5:18 a.m., Sahil Takiar wrote: > > common/src/java/org/apache/hive/common/util/HiveStringUtils.java > > Lines 1083 (patched) > > <https://reviews.apache.org/r/60445/diff/1/?file=1763215#file1763215line1083> > > > > is this copied from somewhere, or is this logic new?
This code is new. > On June 28, 2017, 5:18 a.m., Sahil Takiar wrote: > > common/src/java/org/apache/hive/common/util/HiveStringUtils.java > > Lines 1104 (patched) > > <https://reviews.apache.org/r/60445/diff/1/?file=1763215#file1763215line1104> > > > > are there any changes to this method, or was it just moved from > > `Commands.java` This code was moved. Peter requests updated javadoc so I will change that in the next revision. > On June 28, 2017, 5:18 a.m., Sahil Takiar wrote: > > common/src/java/org/apache/hive/common/util/HiveStringUtils.java > > Lines 1136 (patched) > > <https://reviews.apache.org/r/60445/diff/1/?file=1763215#file1763215line1136> > > > > new logic, or copied from beeline? Moved from beeline > On June 28, 2017, 5:18 a.m., Sahil Takiar wrote: > > common/src/test/org/apache/hive/common/util/TestHiveStringUtils.java > > Lines 113-115 (patched) > > <https://reviews.apache.org/r/60445/diff/1/?file=1763216#file1763216line113> > > > > nit: remove extra lines Fixed in next patch - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60445/#review179073 ----------------------------------------------------------- On June 26, 2017, 8:35 p.m., Andrew Sherman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60445/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 8:35 p.m.) > > > Review request for hive and Sahil Takiar. > > > Bugs: HIVE-16935 > https://issues.apache.org/jira/browse/HIVE-16935 > > > Repository: hive-git > > > Description > ------- > > We strip sql comments from a command string. The stripped command is use to > determine which > CommandProcessor will execute the command. If the CommandProcessorFactory > does not select a special > CommandProcessor then we execute the original unstripped command so that the > sql parser can remove comments. > Move BeeLine's comment stripping code to HiveStringUtils and change BeeLine > to call it from there > Add a better test with separate tokens for "set role" in > TestCommandProcessorFactory. > Add a test case for comment removal in set_processor_namespaces.q using an > indented comment as > unindented comments are removed by the test driver. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java 3b2d72ed79 > beeline/src/test/org/apache/hive/beeline/TestCommands.java 04c939a04c > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 27fd66d35e > common/src/java/org/apache/hive/common/util/HiveStringUtils.java 4a6413a7c3 > common/src/test/org/apache/hive/common/util/TestHiveStringUtils.java > 6bd7037152 > > ql/src/test/org/apache/hadoop/hive/ql/processors/TestCommandProcessorFactory.java > 21bdcf4443 > ql/src/test/queries/clientpositive/set_processor_namespaces.q 612807f0c8 > ql/src/test/results/clientpositive/set_processor_namespaces.q.out > c05ce4d61d > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java > 2dd90b69b3 > > > Diff: https://reviews.apache.org/r/60445/diff/1/ > > > Testing > ------- > > Added new test case. > Hand tested with Hue and Jdbc. > > > Thanks, > > Andrew Sherman > >
