-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60349/
-----------------------------------------------------------
(Updated June 26, 2017, 9:06 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Updated golden files
Bugs: HIVE-16793
https://issues.apache.org/jira/browse/HIVE-16793
Repository: hive-git
Description
-------
For scalar subqueries we skip adding UDF sq_count_check which have aggregates
but we add it if there is a explicit group by present. We can skip it if group
by is present but group by keys are constant. This patch adds a rule to do this
optimization.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRemoveSqCountCheck.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
83d3f7436d
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 88054e7379
ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out
0a780db7ef
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ceccc88b2e
ql/src/test/results/clientpositive/llap/subquery_select.q.out 440e9d7b55
ql/src/test/results/clientpositive/perf/query23.q.out ebd2271108
ql/src/test/results/clientpositive/perf/query44.q.out 07187b14d4
ql/src/test/results/clientpositive/perf/query54.q.out b9d0b8b376
ql/src/test/results/clientpositive/perf/query58.q.out 5b37f36386
ql/src/test/results/clientpositive/perf/query6.q.out 03fff79951
Diff: https://reviews.apache.org/r/60349/diff/2/
Changes: https://reviews.apache.org/r/60349/diff/1-2/
Testing
-------
-Pre-commit testing
- new tests
Thanks,
Vineet Garg
