-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60349/
-----------------------------------------------------------
(Updated July 12, 2017, 9:57 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Addressed review comments
Bugs: HIVE-16793
https://issues.apache.org/jira/browse/HIVE-16793
Repository: hive-git
Description
-------
For scalar subqueries we skip adding UDF sq_count_check which have aggregates
but we add it if there is a explicit group by present. We can skip it if group
by is present but group by keys are constant. This patch adds a rule to do this
optimization.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5700fb9325
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRemoveSqCountCheck.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
83d3f7436d
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 88054e7379
ql/src/test/queries/clientpositive/subquery_scalar.q 876a1e98f8
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 3a0d1464c5
ql/src/test/results/clientpositive/perf/query14.q.out 42bad8da14
ql/src/test/results/clientpositive/perf/query23.q.out ebd2271108
Diff: https://reviews.apache.org/r/60349/diff/3/
Changes: https://reviews.apache.org/r/60349/diff/2-3/
Testing
-------
-Pre-commit testing
- new tests
Thanks,
Vineet Garg
