+1 - think this will be a great addition to Hive. Helping us catch issues earlier, keeping the Hive code cleaner, etc. Getting the basic Yetus checks to work seems like a great start, do we have follow JIRAs to get more YETUS tests integrated - e.g. FindBugs?
On Mon, Nov 6, 2017 at 10:29 AM, Vihang Karajgaonkar <vih...@cloudera.com> wrote: > Thanks Adam for this work. This is definitely useful and a good addition to > our test infrastructure. > > Can we fix the existing issues pointed by Yetus (in a separate JIRA) so > that we have a +1 from yetus on the current code? Once that is done, > committers can help keep it green as they review patches and merge it. > > Thanks, > Vihang > > On Mon, Nov 6, 2017 at 9:04 AM, Thejas Nair <thejas.n...@gmail.com> wrote: > > > +1 > > Yes, I think this can help us catch many issues early on, it will be very > > useful! > > > > > > On Mon, Nov 6, 2017 at 7:43 AM, Adam Szita <sz...@cloudera.com> wrote: > > > > > Hi all, > > > > > > As a next step of test subsystem improvements we would like to have the > > > Yetus check integrated with the ptest framework. This means that > > whenever a > > > new patch is uploaded - along with the already existing Precommit test > > run > > > - Hive's Yetus patch check script would be triggered also. This script > > runs > > > checkstyle, findbugs, ASF license check, etc with and without the > > submitted > > > patch applied and reports the diffs (i.e. how many checkstyle problems > > does > > > the patch introduce). > > > > > > It would be executed parallel to the ptest test execution and report > back > > > the results as a (another) jira comment to the issue in question. > > > In the last days I've been working on this (HIVE-16748) and a patch is > > > ready to make this happen. A sample Yetus result comment is available > at > > > https://issues.apache.org/jira/browse/HIVE-16748? > > > focusedCommentId=16218616&page=com.atlassian.jira. > > > plugin.system.issuetabpanels:comment-tabpanel#comment-16218616 > > > > > > We think this would be a useful tool for us developers and would like > to > > go > > > ahead with this change, but we're also curious about your input in this > > > matter. Please let us know what you think about this change. > > > > > > Thanks, > > > Adam > > > > > > -- Sahil Takiar Software Engineer at Cloudera takiar.sa...@gmail.com | (510) 673-0309
