> On Jan. 5, 2018, 1:07 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > > Lines 155 (patched) > > <https://reviews.apache.org/r/64903/diff/1/?file=1929629#file1929629line159> > > > > OrcInputFormat does some adjustments for ACID. > > > > https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java#L1648 > > > > Maybe the same applies here.
It's actually unrelated. I remember there was a bug where includes would be null in extremely rare cases so this code was added. However over time it seems to have been moved after columnIds assignment so it would still break stuff. I am moving it back in front so the other code won't NPE. Looks like the below code would handle ACID. > On Jan. 5, 2018, 1:07 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > > Lines 419 (patched) > > <https://reviews.apache.org/r/64903/diff/1/?file=1929629#file1929629line427> > > > > log the chosen queue size for debugging. Also will be good if current > > queue size can be printed periodically or when limits are reached once or > > expose as metrics. Limits are per fragment and never change atm. Added the logging at init time - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64903/#review194816 ----------------------------------------------------------- On Jan. 3, 2018, 2:32 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64903/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 2:32 a.m.) > > > Review request for hive, Gopal V and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java be83489cb3 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > 4dc107a6cb > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > 77c8ade5c9 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > 52a9c238ac > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java > 1f3f4d2b4f > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 373af76cf6 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > 29304977a9 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 21f90a7853 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java > 4b0a1ceca4 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Consumer.java > 43c56472f3 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > 29cef30d5f > > > Diff: https://reviews.apache.org/r/64903/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
