> On Jan. 5, 2018, 1:32 a.m., Jason Dere wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > > Lines 520 (patched) > > <https://reviews.apache.org/r/64903/diff/1/?file=1929629#file1929629line547> > > > > Maybe interesting to save/log the number of iterations spent in this > > loop, if iterations > 1?
Hmm... it's just wait time. Not sure if number of iterations matter. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64903/#review194821 ----------------------------------------------------------- On Jan. 3, 2018, 2:32 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64903/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 2:32 a.m.) > > > Review request for hive, Gopal V and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java be83489cb3 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > 4dc107a6cb > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > 77c8ade5c9 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > 52a9c238ac > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java > 1f3f4d2b4f > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 373af76cf6 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > 29304977a9 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 21f90a7853 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java > 4b0a1ceca4 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Consumer.java > 43c56472f3 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > 29cef30d5f > > > Diff: https://reviews.apache.org/r/64903/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
