----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195809 -----------------------------------------------------------
Thanks Marta for the patch. Just one question. Peter standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java Lines 341 (patched) <https://reviews.apache.org/r/65213/#comment275134> Question: Does this behave the same way for external tables too? - Peter Vary On Jan. 18, 2018, 1:11 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65213/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 1:11 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18479 > https://issues.apache.org/jira/browse/HIVE-18479 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - boolean dropPartition(String, String, List<String>, boolean) > - boolean dropPartition(String, String, List<String>, PartitionDropOptions) > - boolean dropPartition(String, String, String, boolean) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65213/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
