> On Jan. 19, 2018, 11:50 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > > Lines 341 (patched) > > <https://reviews.apache.org/r/65213/diff/1/?file=1941487#file1941487line341> > > > > Question: Does this behave the same way for external tables too?
Thanks a lot Peter for the review. That's a good point. :) No, with external tables, the data won't be deleted. Added an additional test case where deleteData = purge = true with an external table and the test checks if the partitions is dropped but the location is not deleted. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195809 ----------------------------------------------------------- On Jan. 22, 2018, 12:38 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65213/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 12:38 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18479 > https://issues.apache.org/jira/browse/HIVE-18479 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - boolean dropPartition(String, String, List<String>, boolean) > - boolean dropPartition(String, String, List<String>, PartitionDropOptions) > - boolean dropPartition(String, String, String, boolean) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65213/diff/2/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
