> On Jan. 19, 2018, 4:36 p.m., Adam Szita wrote: > > Looks good! I added small issues to fix, similarly with the dropPartitions > > change: some helper methods could be static (the ones that don't depend on > > HMS client certainly) and some could use Lists.newArrayList
Thanks a lot Adam for the review. I made some helper methods static and also used the Lists.newArrayList where is was needed. > On Jan. 19, 2018, 4:36 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > > Lines 68 (patched) > > <https://reviews.apache.org/r/65219/diff/1/?file=1942108#file1942108line68> > > > > Again this may be -1 instead, when MAX as a value is not used for any > > other reason than returning all partitions No reason, just missed it. Thanks for the hint, fixed it. > On Jan. 19, 2018, 4:36 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > > Lines 672 (patched) > > <https://reviews.apache.org/r/65219/diff/1/?file=1942108#file1942108line672> > > > > This is found multiple times in the code, should we create a method for > > it? I refactored a bit handling the creation time, so these duplications are eliminated. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195825 ----------------------------------------------------------- On Jan. 18, 2018, 4:58 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65219/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 4:58 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18486 > https://issues.apache.org/jira/browse/HIVE-18486 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - Partition add_partition(Partition) > - int add_partitions(List<Partition>) > - List<Partition> add_partitions(List<Partition>, boolean, boolean) > > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65219/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
