-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65219/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 2:40 p.m.)
Review request for hive, Peter Vary and Adam Szita.
Changes
-------
Addressed the review findings.
- Added tests for creating partitions with default attribute values.
- Added tests for creating partitions without columns and with invalid or
incomplete colum infos
- Added tests for creating partitions without serde info
- Added tests for creating partitions for external table with and without
location being set
- Made some helper methods static
- Used the List.newArrayList method where it is needed
- Changed the value of the MAX variable to -1
- Removed the creation time checks where it was not necessary
- Fixed some checkstyle issues
Bugs: HIVE-18486
https://issues.apache.org/jira/browse/HIVE-18486
Repository: hive-git
Description
-------
The following methods of IMetaStoreClient are covered by this test.
- Partition add_partition(Partition)
- int add_partitions(List<Partition>)
- List<Partition> add_partitions(List<Partition>, boolean, boolean)
The test covers not just the happy pathes, but the edge cases as well.
Diffs (updated)
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java
PRE-CREATION
Diff: https://reviews.apache.org/r/65219/diff/2/
Changes: https://reviews.apache.org/r/65219/diff/1-2/
Testing
-------
Run the tests
Thanks,
Marta Kuczora
