-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/#review196437
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
Line 4077 (original), 4077 (patched)
<https://reviews.apache.org/r/65356/#comment276082>

    as far as I can tell every call to this method, passes null for isBaseDir.  
Can this be removed?


- Eugene Koifman


On Jan. 26, 2018, 9:03 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65356/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2018, 9:03 p.m.)
> 
> 
> Review request for hive and Eugene Koifman.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2e1fd37d4a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3 
> 
> 
> Diff: https://reviews.apache.org/r/65356/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Reply via email to