> On Jan. 29, 2018, 5:13 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > > Line 4077 (original), 4077 (patched) > > <https://reviews.apache.org/r/65356/diff/1/?file=1946981#file1946981line4077> > > > > as far as I can tell every call to this method, passes null for > > isBaseDir. Can this be removed? > > Sergey Shelukhin wrote: > Nm, it was supposed to be passed in one place where available. > > Eugene Koifman wrote: > i don't understand this. are you saying there is a place where non-null > value is passed in?
Yes - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65356/#review196437 ----------------------------------------------------------- On Jan. 31, 2018, 12:21 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65356/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 12:21 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7348faa9bb > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000 > > > Diff: https://reviews.apache.org/r/65356/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
