> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 650 (patched) > > <https://reviews.apache.org/r/65415/diff/2/?file=1950630#file1950630line658> > > > > I might be missing something but I don't see why should quickstats be > > calculated differently for transactional tables...quickstats is num_files > > and total bytes on disk - these things apply to acid tables as well
For acid tables, files in old delta directories and such do not belong to the table data set. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196696 ----------------------------------------------------------- On Feb. 24, 2018, 2:09 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65415/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2018, 2:09 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > f.,v fbghdscd > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java b490325091 > > ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java > 0a82225d4a > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 70fcd2c142 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8b0af3e5c8 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 67d05e65dd > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 7d2de75315 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > cd6f1ee692 > ql/src/java/org/apache/hadoop/hive/ql/plan/BasicStatsWork.java a4e770ce95 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java > 946c300750 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 1d7660e8b2 > ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 05b0474e90 > ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java > d84cf136d5 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 89354a2d34 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c6e34a8a22 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 50f873a013 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 2599ab103e > > > Diff: https://reviews.apache.org/r/65415/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >