> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > > Line 157 (original), 162 (patched) > > <https://reviews.apache.org/r/65415/diff/2/?file=1950625#file1950625line163> > > > > I feel that currently the stats system is half-blind when it comes to > > acid tables...because the autogather operations are somewhat useless on > > them... > > I was thinking about the following: removing this condition to collect > > stats even in case basic stats are off; would enable the stats to gather a > > total "rowtraffic" - which might be good enough for an estimation ; and it > > may give the join order optimization a chance to do its job better for > > acid/insert_only tables which have not been updated explicitly updated for > > a long time... > > > > This could be probably done as a separate change (because it will > > probably rewrite every second q.out) - what do you think about it?
filed a jira - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196696 ----------------------------------------------------------- On Feb. 27, 2018, 3:14 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65415/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 3:14 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > f.,v fbghdscd > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java > df77a4a2f2 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java b490325091 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java fd8423129f > > ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java > 0a82225d4a > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 70fcd2c142 > ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java > 1a63d3f971 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8b0af3e5c8 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 67d05e65dd > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 7d2de75315 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > cd6f1ee692 > ql/src/java/org/apache/hadoop/hive/ql/plan/BasicStatsWork.java a4e770ce95 > > ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > 8ce0cb05b6 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java > 946c300750 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 1d7660e8b2 > ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java > 7591c0681b > ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 05b0474e90 > ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java > d84cf136d5 > ql/src/test/results/clientpositive/autoColumnStats_4.q.out 9c0e020351 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 59190893e6 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 89354a2d34 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c6e34a8a22 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java > 20c10607bb > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > b44ff8ce47 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 50f873a013 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 2599ab103e > > > Diff: https://reviews.apache.org/r/65415/diff/4/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >