-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67485/
-----------------------------------------------------------
(Updated jún. 14, 2018, 10:57 de)
Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar.
Changes
-------
Updated the patch based on Vihang's comments:
- Refactored HiveMetaStore.isSubdirectory to FileUtils, which only uses strings
as input
- RawStore.getPartitionLocations got a new input parameter as a baseLocation,
and return location string only outside the location. Thus saving memory
- Added new test method, to see, that the partitions where the location is
outside the table location are removed too.
Bugs: HIVE-19783
https://issues.apache.org/jira/browse/HIVE-19783
Repository: hive-git
Description
-------
Added a new getPartitionLocations method to the RawStore interface.
Implemented getPartitionLocations in ObjectStore using JDQL.
Question: In CachedObjectStore: Shall I call rawStore.getPartitionLocations or
reimplement it using getPartitions?
Modified dropPartitionsAndGetLocations:
- Instead of querying every partition data. Query only the locations using the
new interface method
- Removed partKeys parameter which become unneccessary
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
8f9a03fcd1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
9241e294ae
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
660b119bd1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
bbbdf21d4b
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
7c3588d104
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java
ec9e9e2b95
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
7c7429db15
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
e4f2a17d64
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
7ad8053cea
Diff: https://reviews.apache.org/r/67485/diff/3/
Changes: https://reviews.apache.org/r/67485/diff/2-3/
Testing
-------
Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and
drop)
Thanks,
Peter Vary
