> On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > > Thanks a lot for the changes. Mostly looks good to me. Couple of minor > > suggestions.
Thanks for the review Vihang! > On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 2854 (patched) > > <https://reviews.apache.org/r/67485/diff/4/?file=2042293#file2042293line2854> > > > > this line should be moved to finally Done. Thanks! > On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > > Line 170 (original), 170 (patched) > > <https://reviews.apache.org/r/67485/diff/4/?file=2042300#file2042300line170> > > > > any particular reason to change this 2? I think it will be usefull to > > have a batch size which is not same as number of partitions so that > > batching logic is exercised. The test change is about changing 1 partition to point to an external directory, so removing that directory is tested as well. So there will be 3 partitions after the change (this is not changed), but 2 inside the table root dir, and 1 outside it. The 3rd partition is added by this code: // Add an external partition too new PartitionBuilder() .inTable(testTables[3]) .addValue("a2") .setLocation(metaStore.getWarehouseRoot() + "/external/a2") .addToTable(client, metaStore.getConf()); - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review205084 ----------------------------------------------------------- On jún. 21, 2018, 8 de, Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67485/ > ----------------------------------------------------------- > > (Updated jún. 21, 2018, 8 de) > > > Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. > > > Bugs: HIVE-19783 > https://issues.apache.org/jira/browse/HIVE-19783 > > > Repository: hive-git > > > Description > ------- > > Added a new getPartitionLocations method to the RawStore interface. > > Implemented getPartitionLocations in ObjectStore using JDQL. > Question: In CachedObjectStore: Shall I call rawStore.getPartitionLocations > or reimplement it using getPartitions? > > Modified dropPartitionsAndGetLocations: > - Instead of querying every partition data. Query only the locations using > the new interface method > - Removed partKeys parameter which become unneccessary > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 8f9a03fcd1 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > e88f9a5fee > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > e99f888eef > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > bbbdf21d4b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 7c3588d104 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > ec9e9e2b95 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 7c7429db15 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > e4f2a17d64 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java > 1a57df2680 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > e1c3dcb47f > > > Diff: https://reviews.apache.org/r/67485/diff/5/ > > > Testing > ------- > > Run the TestTablesCreateDropAlterTruncate test (partitioned table creation > and drop) > > > Thanks, > > Peter Vary > >
