hustfeiwang commented on a change in pull request #555: [HIVE-21345][CLI] Fix
the error when hive cliDriver parses sql statement h semicolon in a pair of
double quote
URL: https://github.com/apache/hive/pull/555#discussion_r261174150
##########
File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
##########
@@ -445,6 +445,17 @@ public void handle(Signal signal) {
}
break;
case '"':
+ if (!escape) {
Review comment:
> How is this different to the case below for `'\''`? Maybe I'm missing
something but I can't see a difference and the current code has both cases
dropping to the same block so the end effect would be the same surely?
There is not different to the case below for`'\''`.
I think single quotes and double quotes work the same in a sql statement,
with a constant value or a pattern inside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
