hustfeiwang commented on a change in pull request #555: [HIVE-21345][CLI] Fix
the error when hive cliDriver parses sql statement h semicolon in a pair of
double quote
URL: https://github.com/apache/hive/pull/555#discussion_r261180675
##########
File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
##########
@@ -445,6 +445,17 @@ public void handle(Signal signal) {
}
break;
case '"':
+ if (!escape) {
Review comment:
> If it's not different then why introduce duplicated code for both cases?
Surely the way it was previously both cases would drop down to the same code
block which is effectively the same as this?
Oh sorry, you are right. I found this case in spark.
Spark dependent on hive-1.2.1 which process these case incorrectly.
So I override the splitSemicolon method in SparkSQLCLIDriver with scala.
However, scala is different to java.
Scala does not need break to break case.
Thanks, I will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
