----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72433/ -----------------------------------------------------------
Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-23244 https://issues.apache.org/jira/browse/HIVE-23244 Repository: hive-git Description ------- Create View commands are not queries, but commands which have queries as a part of them. Therefore a separate CreateViewAnalyzer is needed which uses SemanticAnalyer to analyze it's query. Diffs ----- common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 8e643fe844 parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b03b0989b8 ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java b82fc5e91d ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AbstractCreateViewAnalyzer.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AbstractCreateViewDesc.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsAnalyzer.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsDesc.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsOperation.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateMaterializedViewDesc.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateMaterializedViewOperation.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewAnalyzer.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewDesc.java d1f36945fb ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewOperation.java f7952a5cc1 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java b578d48ce1 ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4f1e23d7a6 ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7b2e201e5a ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java bef02176c2 ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 9d94b6e2dd ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0de3730351 ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java 2350646c36 ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 2f3fc6c50a ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c75829c272 ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java 07bcef8ee3 ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 980f39b681 ql/src/test/results/clientnegative/create_or_replace_view4.q.out 767cc77596 ql/src/test/results/clientnegative/create_view_failure3.q.out 8b79272f46 ql/src/test/results/clientnegative/create_view_failure5.q.out b7b3984292 ql/src/test/results/clientnegative/create_view_failure6.q.out 6d9fb6461d ql/src/test/results/clientnegative/create_view_failure7.q.out 337dbe889e ql/src/test/results/clientnegative/create_view_failure8.q.out cccb7e4b06 ql/src/test/results/clientnegative/create_view_failure9.q.out eac8cb489e ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out 9496e528e2 ql/src/test/results/clientpositive/create_view.q.out 7414d4749d ql/src/test/results/clientpositive/explain_ddl.q.out aea46d304f ql/src/test/results/clientpositive/llap/create_view_translate.q.out b5d464e716 ql/src/test/results/clientpositive/llap/explainuser_1.q.out 7f0ce5a9c7 ql/src/test/results/clientpositive/llap/lineage3.q.out a4f6e61af4 ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 3fc0074ed4 ql/src/test/results/clientpositive/llap/union_top_level.q.out e0d86b3989 ql/src/test/results/clientpositive/llap/vector_windowing.q.out ca3c6337bf ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out dad999ab1a ql/src/test/results/clientpositive/tez/explainuser_3.q.out 5218c90f0c Diff: https://reviews.apache.org/r/72433/diff/1/ Testing ------- All the tests are still running fine. Thanks, Miklos Gergely